HHH-17246 - Guard against Sybase being configured for truncating trailing zeros #9079
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hibernate-core/src/test/java/org/hibernate/orm/test/id/uuid/SybaseASEUUIDTest.java
Fixed
Show fixed
Hide fixed
hibernate-core/src/test/java/org/hibernate/orm/test/id/uuid/SybaseASEUUIDTest.java
Fixed
Show fixed
Hide fixed
|
@jrenaat It should be possible to detect that Sybase is configured like this, right? Just like we detect certain things about how MySQL or Oracle is configured, when we instantiate their dialects. I think we should start logging warnings for such "bad" config, i.e. this thing, and also non-ANSI nulls. |
hibernate-core/src/main/java/org/hibernate/type/descriptor/jdbc/UUIDasVarBinaryJdbcType.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/type/descriptor/jdbc/UUIDasVarBinaryJdbcType.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/type/descriptor/jdbc/UUIDasVarBinaryJdbcType.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/type/descriptor/jdbc/UUIDasVarBinaryJdbcType.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/type/descriptor/jdbc/UUIDasVarBinaryJdbcType.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/boot/model/process/spi/MetadataBuildingProcess.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/test/java/org/hibernate/orm/test/id/uuid/SybaseASEUUIDTest.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/test/java/org/hibernate/orm/test/id/uuid/SybaseASEUUIDTest.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/test/java/org/hibernate/orm/test/id/uuid/SybaseASEUUIDTest.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/test/java/org/hibernate/orm/test/id/uuid/SybaseASEUUIDTest.java
Outdated
Show resolved
Hide resolved
I tried to find out how to do this, but failed miserably ... |
jrenaat
force-pushed
the
HHH-17246_SybaseUUID
branch
from
eef475e
to
549af2f
Compare
| final Book book = new Book(uuid, "John Doe"); | ||
| session.persist( book ); |
There was a problem hiding this comment.
You want to test what happens when 15 bytes are written, so let's write the first 15 bytes only.
| final Book book = new Book(uuid, "John Doe"); | |
| session.persist( book ); | |
| session.createMutationQuery( "insert into Book(id, author) values (?,'John Doe')" ).setParameter(1, Arrays.copyOf( UUIDJavaType.ToBytesTransformer.transform( uuid ), 15 ) ).executeUpdate(); |
There was a problem hiding this comment.
I do explicitely want to write 16 bytes to the db, and i check if the value recovered is 15 bytes, to ensure that there is effectively some truncation going on; without that i wouldn't have seen that this truncation doesn't happen if in the UuidAsBinaryJdbcType we indicate BINARY as the ddl type code. Truncation only happens if that is VARBINARY
There was a problem hiding this comment.
That said, the UuidAsBinaryJdbcType seems to cause issues for Oracle, irrespective of what ddl type code is used (happens with binary, as well as varbinary)
jrenaat
force-pushed
the
HHH-17246_SybaseUUID
branch
from
549af2f
to
5fc034b
Compare
hibernate-core/src/main/java/org/hibernate/type/descriptor/jdbc/UuidAsBinaryJdbcType.java
Outdated
Show resolved
Hide resolved
| public UUID fromString(CharSequence string) { | ||
| return ToStringTransformer.INSTANCE.parse( string.toString() ); | ||
| public UUID fromString(CharSequence string) { | ||
| return '-' == string.charAt( 8 ) ? ToStringTransformer.INSTANCE.parse( string.toString() ) : NoDashesStringTransformer.INSTANCE.parse( string.toString() ); |
There was a problem hiding this comment.
I don't mind this change, but is it necessary to get some test working?
There was a problem hiding this comment.
Yes, the new UUID type is causing some issues with json in oracle; this change fixes a number of tests in JsonEmbeddableTest, but there is still one remaining (testSelectionItems), that as far as i can tell has to with the function hexToRaw not liking that the UUID hex String contains '-'.
…ling zeros Signed-off-by: Jan Schatteman <[email protected]>
jrenaat
force-pushed
the
HHH-17246_SybaseUUID
branch
from
5fc034b
to
ba8451e
Compare
| @@ -41,7 +41,7 @@ | |||
| return ToStringTransformer.INSTANCE.transform( value ); | |||
| } | |||
|
|
|||
| public UUID fromString(CharSequence string) { | |||
| public UUID fromString(CharSequence string) { | |||
Check notice
Code scanning / CodeQL
Missing Override annotation Note
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-17246