Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HV-1226 Explore usage of method handles instead of core reflection in ReflectionHelper#getValue() #975

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marko-bekhta
Copy link
Member

@marko-bekhta marko-bekhta commented Jun 20, 2018

This PR is an attempt to allow users to switch between method handles and reflection when accessing properties.

EDIT:
And as usual in such cases - some numbers:
method handles:

# Run complete. Total time: 00:00:37
Benchmark                                   Mode  Cnt     Score     Error   Units
SimpleValidation.testSimpleBeanValidation  thrpt   20  2862.591 ± 195.745  ops/ms

reflection:

# Run complete. Total time: 00:00:37
Benchmark                                   Mode  Cnt     Score    Error   Units
SimpleValidation.testSimpleBeanValidation  thrpt   20  2739.682 ± 60.490  ops/ms

@gsmet
Copy link
Member

gsmet commented Feb 17, 2019

OK, for now, let's give up on MethodHandles. (Just so that you don't waste time rebasing this)

Base automatically changed from master to main March 19, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants