Skip to content

Commit

Permalink
External action can't use secrets
Browse files Browse the repository at this point in the history
  • Loading branch information
ThetaSinner committed Jun 25, 2024
1 parent ffbefa2 commit 907df64
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 15 deletions.
12 changes: 0 additions & 12 deletions .github/actions/upload/action.yaml

This file was deleted.

21 changes: 18 additions & 3 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,12 @@ jobs:
# nix build .#hcterm_x86_64-windows
# cp ./result/bin/hcterm.exe deploy/hcterm-x86_64-windows.exe

- uses: ./.github/actions/upload
- name: Upload artifacts to release
if: ${{ github.event_name == 'workflow_dispatch' && github.event.inputs.upload-to-tag != '' }}
env:
GH_TOKEN: ${{ secrets.HRA_GITHUB_TOKEN }}
run: |
gh release upload ${{ github.event.inputs.upload-to-tag }} deploy/*
# build-from-apple:
# runs-on: macos-latest
Expand Down Expand Up @@ -154,7 +159,12 @@ jobs:
# ./result/bin/hcterm --version
# cp ./result/bin/hcterm deploy/hcterm-aarch64-apple
#
# - uses: ./.github/actions/upload
# - name: Upload artifacts to release
# if: ${{ github.event_name == 'workflow_dispatch' && github.event.inputs.upload-to-tag != '' }}
# env:
# GH_TOKEN: ${{ secrets.HRA_GITHUB_TOKEN }}
# run: |
# gh release upload ${{ github.event.inputs.upload-to-tag }} deploy/*
#
# build-from-legacy-apple:
# runs-on: macos-13
Expand Down Expand Up @@ -195,7 +205,12 @@ jobs:
# ./result/bin/hcterm --version
# cp ./result/bin/hcterm deploy/hcterm-x86_64-apple
#
# - uses: ./.github/actions/upload
# - name: Upload artifacts to release
# if: ${{ github.event_name == 'workflow_dispatch' && github.event.inputs.upload-to-tag != '' }}
# env:
# GH_TOKEN: ${{ secrets.HRA_GITHUB_TOKEN }}
# run: |
# gh release upload ${{ github.event.inputs.upload-to-tag }} deploy/*
#
# bundle-x86-64-linux:
# runs-on: ubuntu-latest
Expand Down

0 comments on commit 907df64

Please sign in to comment.