CF Metrics, Tests, and Fixes #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jost Schulte <[email protected]>
Co-authored-by: Jost Schulte <[email protected]>
neonphog
commented
Jul 15, 2024
| @@ -0,0 +1,108 @@ | |||
| import { fromUint8Array, toUint8Array } from 'js-base64'; | |||
There was a problem hiding this comment.
The contents are this file are just consolidated from other files, no code changes here.
neonphog
commented
Jul 15, 2024
Comment on lines
+82
to
+86
| if (this.status !== 200) { | ||
| return new Response(JSON.stringify({ err: 'dead' }), { | ||
| status: this.status, | ||
| }); | ||
| } |
There was a problem hiding this comment.
added these checks that short-circuit cpu time when the object has already errored / closed
neonphog
commented
Jul 15, 2024
| #cpu_ms = 5000 | ||
|
|
||
| kv_namespaces = [ | ||
| { binding = "SBD_COORDINATION", id = "cde857dd4ea745fea55f80daa52a6d5c" } |
There was a problem hiding this comment.
This kv store is where metrics are stored.
neonphog
commented
Jul 15, 2024
| const { pubKeyStr } = parsePubKey(url.pathname); | ||
| let pathParts = url.pathname.split('/'); | ||
|
|
||
| if (pathParts.length === 4 && pathParts[1] === 'metrics') { |
There was a problem hiding this comment.
here's the new metrics entrypoint
ThetaSinner
approved these changes
Jul 16, 2024
| ``` | ||
| # HELP client.count active client count | ||
| # TYPE client.count guage | ||
| client.count 4 |
There was a problem hiding this comment.
Are these recorded somewhere? Otherwise it's just a point in time and it'd be useful to have this recorded over time
There was a problem hiding this comment.
The intention would be for these to be scraped by a grafana somewhere. It'd be too expensive to aggregate them in cloudflare itself.
jost-s
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RESOLVES #29