Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional agent key for app installation #234

Closed
wants to merge 3 commits into from
Closed

Conversation

maackle
Copy link
Collaborator

@maackle maackle commented Aug 23, 2024

No description provided.

@maackle maackle requested review from jost-s and zo-el August 23, 2024 20:56
@JettTech
Copy link
Contributor

JettTech commented Aug 26, 2024

@maackle - Hey, so I looked into this and it looked like the holochain version needed to be bumped in this version for the tests to test your edit against the issue with the dpki present in the most recent holochain version. So I went ahead and bumped the flake version so the CI could run and show the results with the latest. However, even after the flake is updated, there are several tests that error out with a dpki error, so it appears this edit doesn't cover all the cases.

I went ahead and made another pr (#236) to add a no-dpki flag as a param when creating a new conductor for a local scenario as well as in trycp ones. Can you take a look at that pr when you have a chance? Also, the local conductor setup relies on making a call to hc sandbox, which also did not expose a way to omit/edit the conductor's DpkiConfig so I went ahead a made that change as well, so we could move forward with the DNA testing with this latest version of holochain.

When you get a chance can you please take a look at this tryorama pr and its associated one in holochain?

Thanks so much in advance!! ⚡ 💪

@jost-s jost-s deleted the branch develop October 9, 2024 23:27
@jost-s jost-s closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants