Clean up location manager after making updates suspend #4818
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Noticed that we had a few places to clean up and remove overlapping suspend calls
also added in a flush location call to only be called when we need to restart location services to clear out the queue, its also recommended we call it as we use
setMaxWaitTime()
so this felt like the most appropriate place to call it.geofences are also limited to 100 per app so adding in 2 condition checks there. Probably needs a docs update for this one and combined with high accuracy expanded mode will be fun to write 🙃
https://developer.android.com/develop/sensors-and-location/location/geofencing
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#pending based on PR approval and discussion
Any other notes
Tested these changes overnight to ensure it all still works as expected