Add dialog before prompting for Improv permissions #4837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a dialog explaining why the app is about to request permissions for scanning for Improv devices. This should prevent users from denying it because it is not understood. - Move some code from onboarding views and bottom sheet dialogs to utility files where it is now used in more places. - Note that the 2nd prompt may not actually result in a system prompt if it is auto-denied.
dshokouhi
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Based on feedback: add a dialog explaining why the app is about to request permissions for scanning for Improv devices. This should prevent users from denying it because it is not understood. Note that the 2nd prompt may not actually result in a system prompt if it is auto-denied.
Moves some code from onboarding views and bottom sheet dialogs to utility files where it is now used in more places.
Screenshots
Link to pull request in Documentation repository
n/a
Any other notes
related to home-assistant/iOS#3104