Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency fixes for Thermostat and Hygrostat card names and descriptions #22324

Open
NoRi2909 opened this issue Oct 10, 2024 · 3 comments · May be fixed by #22416
Open

Consistency fixes for Thermostat and Hygrostat card names and descriptions #22324

NoRi2909 opened this issue Oct 10, 2024 · 3 comments · May be fixed by #22416
Labels
localization Translations and Localization

Comments

@NoRi2909
Copy link
Contributor

NoRi2909 commented Oct 10, 2024

Describe the issue you are experiencing

There are several issues with the naming and description of the Thermostat and Humidifier (should be Hygrostat) cards.

Describe the behavior you expected

The current description for the Thermostat card is found in:

"thermostat": {
"name": "Thermostat",
"description": "The Thermostat card gives control of your climate entity. Allowing you to change the temperature and mode of the entity.",
"show_current_as_primary": "Show current temperature as primary information"
},

That grammar is broken, should be fixed by using a comma: "The Thermostat card gives control of your climate entity, allowing you to change the temperature and mode of the entity."

But that "your" is also misleading, you can have many climate entities for all your rooms etc., and it should be noted that this works for heating and cooling.

Suggestion:

"The Thermostat card gives control of a climate entity for heating or cooling, allowing you to set its mode and desired temperature."

Similar, but with several inconsistencies:

"humidifier": {
"name": "Humidifier",
"description": "The Humidifier card gives control of your humidifier entity. Allowing you to change the humidity and mode of the entity.",
"show_current_as_primary": "Show current humidity as primary information"
},

Here we have an additional problem, because first of all this should be called "Hygrostat card" like the "Thermostat card" above. And this can control both humidifiers and dehumidifiers, just like heating and cooling above.

So here a suggested complete rewording:

"The Hygrostat card gives control of a humidifier entity for humidifying or dehumdifying, allowing you to set its mode and desired humidity."

Along this fix the name needs to be changed, matching the naming from the Thermostat above.

Steps to reproduce the issue

The thermostat string seems to be replaced by a graphic, but the humidifier text still shows up when adding a card to the dashboard.

What version of Home Assistant Core has the issue?

core-2024.10.1

Additional information

I tested this by creating two helper entities for HVAC and humidifier / dehumdifier.

@NoRi2909
Copy link
Contributor Author

@j4n-e4t Thanks for taking care of the bug report. I try to figure out where I can see the actual changes in the PR to verify, but there is so much overhead for such a simple rewording that I can't tell the forest from the trees 🤓

@NoRi2909
Copy link
Contributor Author

NoRi2909 commented Oct 17, 2024

@j4n-e4t Now I have it …

Was scrolling up and down and overlooked the Tab at the top to d19feb6

The change from "Humidifier" to "Hygrostat" seems to me missing, or not?

"name": "Humidifier",

@j4n-e4t
Copy link
Contributor

j4n-e4t commented Oct 17, 2024

Hygrostat

You're right, I've missed that. Changed it now.

@silamon silamon added the localization Translations and Localization label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization Translations and Localization
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants