-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inconsistency in Thermostat and Hygrostat card names #22416
base: dev
Are you sure you want to change the base?
Fix inconsistency in Thermostat and Hygrostat card names #22416
Conversation
There is documentation that needs to be updated if we are updating the names. |
@silamon OK, that's at https://www.home-assistant.io/dashboards/humidifier/ ? Can the documentation update on https://github.com/home-assistant/home-assistant.io/blob/current/source/_dashboards/humidifier.markdown be included with the PR? Looks like this isn't to complicated with just a three words to be changed from "Humidifier" to "Hygrostat" above and below the graphic. |
No, it can't since the website lives in a separate repo. But I'm currently not sure if this isn't a bit much overhead for such a small change. What do you think? Also, I've noticed that some internal components still refer to the entities as "humidifier". |
The entities are no problem. They remain humidifiers and dehumidifiers. Nothing to change there at all. The entire PR is about making the Hygrostat agnostic about the type of device it controls as it can do both (as it already says in the documentation) This is the main problem here, because in German you can't simply add "(de)" in front of "humidifier" to cover both: |
In the documentation we have this description:
I think we can update the description to explain that it supports humidifier and dehumidifier but I would not change the name for now as it will not be aligned with the |
@piitaya So just as heating / cooling entities are summarized under Climate vs. Humidifier |
If we want to follow HA domains, it should be |
Well, we're already getting confused by the inconsistency. It's all correct on the first line here:
The second line is not consistent at the moment as this is currently:
So we need to fix these two "humidifier" items, starting with the entity. |
BTW, I checked for other card and we already have inconsistencies between type and name ( |
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@googanhiem Can you help out here? |
The thermostat text change works. However, I have concerns with the rename of humidifier to hygrostat, as it's a bit of a niche word in English. Though it is more technically correct, it would be harder for general users to find and understand. |
@googanhiem That problem with "Hygrostat" is solved as we already have the "Generic Hygrostat" in Helpers. So that term is already established within HA: We're not introducing something new here, but rather fixing a major consistency in the naming of the Dashboard card. Users will still find the card using search as this also finds all matches in the descriptions where we still have "humidifier" and "dehumidifier". Note that in translations "humidifier" is currently a big problem.: In German that's a "Luftbefeuchter" while a "dehumidifier" is a "Luftentfeuchter". So there is no way to sum them up as "(de)humidifiers" like in English. |
While Hygrostat technically is the correct word, we feel people will not understand it or feel at home with the word. Thats why we would like to name the card "(de)humidifier" which can also be translated as "Humidifier / Dehumidifier". |
Well, most people will make their humidifier or dehumidifiers smart by first creating a Generic Hygrostat helper to control some smart plug that will turn this on or off. So those will all become familiarized with "Hygrostat" this way anyhow. Then why not make things consistent and use the same for the card that just integrates the Hygrostat into the dashboard? Using "Luftbefeuchter-/Luftentfeuchter-Karte" in German will probably create some spacing issues, perhaps we will then prefer to test drive "Hygrostat" in the German UI … 😃 |
@NoRi2909 It's up to the translator to use the right term in their language. Even we call it "hygrostat", it will be translated by "Humidificateur" in french because we don't have a word for hygrostat. Hygrostat is not commonly use in english but if you have a better word than "Luftbefeuchter-/Luftentfeuchter-Karte" in german, you should use it. |
OK, no problem. I just try to remain as close to English as long as we don't have a German online documentation. So when I think that i would reword that in my language I try to figure out if it does make sense to apply the same change in English, too. Certainly half of my bug reports or PRs now have been triggered that way. Then just add the 'dehumidifier' in English so both device types are covered and we'll see how we'll match that in German. |
fixes: #22324
Breaking change
Proposed change
Rephrase the descriptions of the "Thermostat" and "Hygrostat" cards based on the suggestions of @NoRi2909. (see: #22324)
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: