Remove static height for logbook card

[silamon]

Proposed change

Remove the static height for the logbook card.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New feature (thank you!)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example configuration

Additional information

• This PR fixes or closes issue: fixes Logbook Card doesn't stretch vertically #17258
• This PR is related to issue or discussion:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• There is no commented out code in this PR.
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

Summary by CodeRabbit

• New Features

  • Enhanced the logbook card's configuration handling for improved flexibility in usage.

• Style

  • Updated CSS styles for the logbook card, improving the overall layout and appearance.

[coderabbitai]

Walkthrough

Walkthrough

The recent changes to the HuiLogbookCard class enhance its configuration handling and visual presentation. The getConfigElement method’s return type has been generalized to Promise, which may affect its integration throughout the codebase. Additionally, CSS modifications ensure that the card stretches vertically, addressing layout issues reported by users.

Changes

Files	Change Summary
src/panels/lovelace/cards/hui-logbook-card.ts	Updated getConfigElement return type from Promise<LovelaceCardEditor> to Promise. Adjusted CSS for .content class to set height to 100% and removed styles for ha-logbook.

Assessment against linked issues

Objective	Addressed	Explanation
Logbook Card should stretch vertically (#17258)	✅
Ensure that configuration handling is robust and clear (not specific to an issue)	❌	The change to a generic Promise type may affect type safety and clarity.

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c806b08 and 907919a.

Files selected for processing (1)

• src/panels/lovelace/cards/hui-logbook-card.ts (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• src/panels/lovelace/cards/hui-logbook-card.ts

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[karwosts]

Isn't this making the card too small? Seems to drop to 150px height by default with this change.

[ildar170975]

Shall we provide a separate style for a panel view only?

[silamon]

Shall we provide a separate style for a panel view only?

While it looks like there will be no other solution, I think it would be good if it could just fit the height it gets or can take. It's sticked to 385px right now in the card, which is why it doesn't work that well.

[bramkragten]

The section view should give the card a height, the masonry view will let the card define the height, the panel view should be full screen.

You can use this.layout === "panel" to set styles based on the view.

[github-actions]

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.