-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate entity, device and area name in more info dialog header and entity picker #21951
base: dev
Are you sure you want to change the base?
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe pull request introduces several utility functions for computing names associated with areas, devices, and entities in a Home Assistant environment. New files are created to define these functions, which enhance the retrieval and presentation of entity-related information. Additionally, modifications are made to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
38e8471
to
5456a65
Compare
5456a65
to
8464b00
Compare
Proposed change
An attempt to improve more info dialog for entities.
For now it uses the backward compatibility with
friendly_name
. We should use entry registry for that buthas_entity_name
should be exposed inEntityRegistryDisplayEntry
for that.Needs home-assistant/core#125832
More info dialog
With device and area
Using device name as entity name (or empty entity name)
No device, no area
Entity picker
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed:
Summary by CodeRabbit
New Features
MoreInfoDialog
to display more structured information, including device and area names alongside the main entity name.Bug Fixes
Style
MoreInfoDialog
with updated styling for title and subtitle presentation.