-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update more-info dialog layout for weather entities #22818
base: dev
Are you sure you want to change the base?
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
The "Forecast:" looks a bit out of place IMHO. I wonder if you could just drop it. It's quite clear that it's a forecast with the dates anyway. I prefer the list instead of the badges. Overall, this makes the dialog more stylish, and I think that's a good thing! |
I like it! Great improvement. I also like the list better than the badges. What happens to the forecast when there are more than 6 forecasts? Like for an hourly forecast that has maybe 24 forecasts? Will it scroll horizontally? |
This reverts commit 89ab0f6.
Switched back to list for attributes. Currently it's truncating the forecasts to 6, but I can work on making them scroll. |
Proposed change
This updates the more-info dialog for weather entities to more closely match the newer styling of the weather forecast card.
(red color is the theme on my dev system)
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: