-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move date-range-picker to Top for Logbook and History #22947
base: dev
Are you sure you want to change the base?
Move date-range-picker to Top for Logbook and History #22947
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@boern99 can you add a mobile screenshot too please? |
|
In your mobile screenshot I miss the button to select a date? |
can be selected by clicking on the date |
should i use a shorter Date Format? But when i leave the time Information: it would need more space than in Energy Dashboard: 2 Lines for start and end date as in this PR? Leave the Dateselector until there is no space left? Would it be better to hide the Date and leave the Dateselector? If you like to change the code feel free to make a Suggestion. |
It's a good idea, but we have to discuss this with the UX team. I am pretty sure we can get an awesome design to improve this selector, it is possible that it can take some time. |
Breaking change
Proposed change
This is an missing Style-Improvement for bed470f
@wendevlin: referring your discussion: #22802 (comment)
Displays Prev. and Next buttons also on mobiles.
Similar to the Energy Dashboard, selecting the date in the header area offers added value, especially on mobile devices.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: