Add addons picker in generate backup dialog #22951
Draft
+190
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bramkragten
reviewed
Nov 21, 2024
| @query("ha-md-dialog") private _dialog?: HaMdDialog; | ||
|
|
||
| public showDialog(_params: GenerateBackupDialogParams): void { | ||
| this._step = STEPS[0]; | ||
| this._formData = INITIAL_FORM_DATA; | ||
| this._params = _params; | ||
| this._fetchAgents(); | ||
| if (isComponentLoaded(this.hass, "hassio")) { | ||
| this._fetchAddons(); | ||
| } | ||
| } | ||
|
|
||
| private _dialogClosed() { |
There was a problem hiding this comment.
We should remove _addons from memory too on close
bramkragten
reviewed
Nov 21, 2024
| @@ -238,7 +286,8 @@ class DialogGenerateBackup extends LitElement implements HassDialog { | |||
| What locations you want to automatically backup to. | |||
| </span> | |||
| <ha-md-select | |||
| @change=${this._agentModeChanged} | |||
| .id=${"agents_mode"} | |||
There was a problem hiding this comment.
Suggested change
| .id=${"agents_mode"} | |
| id="agents_mode" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Basic support for add-ons selection.
I will look to refactor the
ha-backup-data-pickerto useha-backup-addons-pickerin another PR.Also
ha-backup-addons-pickerneeds to be updated to use the same style asha-backup-addons-pickerLooks like the addons are not really in the backup after the creation. I will check with core team.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: