-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Jellyfin remote #34871
base: next
Are you sure you want to change the base?
Add Jellyfin remote #34871
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
WalkthroughWalkthroughThe changes introduce a new category and platform for the Jellyfin integration in Home Assistant. A new Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant HomeAssistant
participant JellyfinClient
User->>HomeAssistant: Send remote command
HomeAssistant->>JellyfinClient: Forward command
JellyfinClient-->>HomeAssistant: Acknowledge command
HomeAssistant-->>User: Confirm command sent
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
source/_integrations/jellyfin.markdown (1)
33-48
: Excellent addition of theRemote
entity functionality and example YAML script!The new section clearly describes the purpose and usage of the
Remote
entity for sending remote commands to the Jellyfin client. The example YAML script provides a helpful illustration of how to use this feature to navigate and select items on the client interface.Just one minor formatting suggestion:
To adhere to the Markdown formatting guidelines, please add blank lines before and after the fenced code block. Here's the suggested change:
This integration also creates a `Remote` entity for sending [remote commands](https://github.com/jellyfin/jellyfin/blob/master/MediaBrowser.Model/Session/GeneralCommandType.cs) to the client, if supported. For example, this can be used to tell the client to navigate right twice, down once, and select the focused item: + ```yaml jellyfin_remote_script: alias: "Jellyfin Remote Script" sequence: - action: remote.send_command target: entity_id: remote.jellyfin_client data: delay_secs: 1.5 command: - MoveRight - MoveRight - MoveDown - Select
<details> <summary>Tools</summary> <details> <summary>Markdownlint</summary><blockquote> 34-34: null Fenced code blocks should be surrounded by blank lines (MD031, blanks-around-fences) </blockquote></details> </details> </blockquote></details> </blockquote></details> <details> <summary>Review details</summary> **Configuration used: CodeRabbit UI** **Review profile: CHILL** <details> <summary>Commits</summary> Files that changed from the base of the PR and between 1f7762498b3886d8b5facd3631565ca7272cb7d9 and 057d4c16c22897552c7557606af277225c91a476. </details> <details> <summary>Files selected for processing (1)</summary> * source/_integrations/jellyfin.markdown (3 hunks) </details> <details> <summary>Additional context used</summary> <details> <summary>Markdownlint</summary><blockquote> <details> <summary>source/_integrations/jellyfin.markdown</summary><blockquote> 34-34: null Fenced code blocks should be surrounded by blank lines (MD031, blanks-around-fences) </blockquote></details> </blockquote></details> </details> <details> <summary>Additional comments not posted (3)</summary><blockquote> <details> <summary>source/_integrations/jellyfin.markdown (3)</summary><blockquote> `7-7`: **LGTM!** The addition of the "Remote" category to `ha_category` aligns with the PR objective and is consistent with the AI-generated summary. --- `19-19`: **LGTM!** The addition of the "remote" platform to `ha_platforms` aligns with the PR objective and is consistent with the AI-generated summary. --- `49-49`: **LGTM!** The addition of the blank line after the fenced code block adheres to the Markdown formatting guidelines and addresses the static analysis hint. </blockquote></details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
Update for home-assistant/core#126461
057d4c1
to
2431936
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @ianhattendorf 👍
Proposed change
Add Jellyfin remote.
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit
Remote
entity for remote commands, enhancing interaction with the client interface.