-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ezviz battery work mode #35744
base: next
Are you sure you want to change the base?
Ezviz battery work mode #35744
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 Walkthrough📝 Walkthrough📝 Walkthrough📝 WalkthroughWalkthroughThe changes introduce a new section titled "Battery work mode" to the EZVIZ integration documentation. This section describes five battery work modes available for battery-powered cameras: "Plugged in," "High performance," "Power save," "Super power saving," and "Custom." Each mode includes specific functionality descriptions. Additionally, the existing content has been slightly reorganized to incorporate this new section, but there are no significant changes to the logic, error handling, or control flow in the documentation. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Documentation
User->>Documentation: Request information on battery modes
Documentation-->>User: Provide details on "Plugged in", "High performance", "Power save", "Super power saving", "Custom"
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (3)
source/_integrations/ezviz.markdown (3)
163-164
: Add more context about accessing the work mode settingThe text explains the purpose but doesn't indicate where users can find this setting in Home Assistant.
-For battery powered cameras, you can use this entity to select the battery work mode to optimize your battery consumption. +For battery powered cameras, you can use the "Work Mode" select entity to optimize your battery consumption. This setting can be found in the device controls for your EZVIZ camera.
167-171
: Improve consistency and clarity in work mode descriptions
- Capitalize the first word of each description for consistency
- Add more detail about the custom mode scheduling
| Plugged in | The camera will keep recording. The camera should be plugged in. | -| High performance | One video clip is longer but saves less power. | -| Power save | One video clip is shorter and saves more power. | -| Super power saving | Sleep mode is on. Active live view can wake up the camera. | -| Custom | The camera will use the schedule(s) registered in the app | +| High performance | One video clip is longer but saves less power. | +| Power save | One video clip is shorter and saves more power. | +| Super power saving | Sleep mode is on. Active live view can wake up the camera. | +| Custom | The camera will use the custom recording schedules configured in the EZVIZ mobile app. |🧰 Tools
🪛 LanguageTool
[grammar] ~170-~170: This is normally spelled as one word.
Context: ... | | Super power saving | Sleep mode is on. Active l...(SUPER_COMPOUNDS)
170-170
: Add cross-reference to wake device serviceFor the "Super power saving" mode, it would be helpful to add a reference to the
wake_device
service that was documented earlier in the file.-| Super power saving | Sleep mode is on. Active live view can wake up the camera. | +| Super power saving | Sleep mode is on. Active live view can wake up the camera. You can also use the `wake_device` service to wake the camera programmatically. |🧰 Tools
🪛 LanguageTool
[grammar] ~170-~170: This is normally spelled as one word.
Context: ... | | Super power saving | Sleep mode is on. Active l...(SUPER_COMPOUNDS)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
source/_integrations/ezviz.markdown
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/ezviz.markdown
[grammar] ~170-~170: This is normally spelled as one word.
Context: ... | | Super power saving | Sleep mode is on. Active l...
(SUPER_COMPOUNDS)
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Approved. Can be merged as soon as the parent PR gets merged.
Proposed change
Update documentation for new EZVIZ select entity: Work Mode.
original PR by @pjbuffard: #30359
code change PR: home-assistant/core#130478
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit