Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker documentation #35877

Draft
wants to merge 1 commit into
base: current
Choose a base branch
from
Draft

Conversation

MPParsley
Copy link

@MPParsley MPParsley commented Nov 21, 2024

Proposed change

Adding docs for Docker users connecting to Tahoma service.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • New Features
    • Added a section addressing Docker connectivity issues with the Tahoma service.
    • Provided guidance on resolving hostname resolution errors for the Tahoma API service.
  • Documentation
    • Updated documentation to include specific error messages and troubleshooting advice.

@home-assistant home-assistant bot added the current This PR goes into the current branch label Nov 21, 2024
Copy link

netlify bot commented Nov 21, 2024

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 4f1319b
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/673f054a28de36000896daff
😎 Deploy Preview https://deploy-preview-35877--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Comment on lines +133 to +142
### Docker could not connect to Tahoma

If you are using Docker, it's possible that the container running Home Assistant doesn't have access to the hostname of the Tahoma service running the API.

```
curl -I gateway-xxxx-xxxx-xxxx.local:8443
curl: (6) Could not resolve host: gateway-xxxx-xxxx-xxxx.local
```

Make sure Home Assistant has access to the service or use the IP address instead of the hostname.
Copy link
Member

@frenck frenck Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems quite impossible; how can this happen?

The only thing I can thing about is: Running our containers in an unsupported way?

@home-assistant home-assistant bot marked this pull request as draft November 21, 2024 10:05
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Copy link
Contributor

coderabbitai bot commented Nov 21, 2024

📝 Walkthrough

Walkthrough

The changes introduce a new section in the Overkiz integration documentation, specifically addressing connectivity issues between Docker and the Tahoma service. This section includes an example of a specific error message that users may encounter and provides guidance on resolving the issue by ensuring Home Assistant has access to the Tahoma service or by using the service's IP address instead of its hostname. The overall structure of the document remains unchanged.

Changes

File Change Summary
source/_integrations/overkiz.markdown Added a new section titled "Docker could not connect to Tahoma," detailing connectivity issues and solutions.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Docker
    participant Tahoma API

    User->>Docker: Start Home Assistant container
    Docker->>Tahoma API: Attempt to connect
    alt Connection successful
        Docker->>User: Connection established
    else Connection failed
        Docker->>User: Display error message
        User->>Docker: Check access
        alt Access issue
            User->>Docker: Use IP address instead of hostname
        end
    end
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (2)
source/_integrations/overkiz.markdown (2)

135-136: Enhance the technical accuracy of the issue description.

The current description could be more precise. Consider this revision for better clarity:

-If you are using Docker, it's possible that the container running Home Assistant doesn't have access to the hostname of the Tahoma service running the API.
+When running Home Assistant in Docker, the container may fail to resolve the Tahoma gateway's hostname due to DNS resolution limitations in the Docker network.
🧰 Tools
🪛 LanguageTool

[style] ~135-~135: For conciseness, try rephrasing this sentence.
Context: ...ect to Tahoma If you are using Docker, it's possible that the container running Home Assistant doesn't have access to t...

(MAY_MIGHT_BE)


137-140: Add language specification and improve the code example.

The code block should specify the language and provide more context about the command.

-```
+```bash
+# Test connection to Tahoma gateway
 curl -I gateway-xxxx-xxxx-xxxx.local:8443
 curl: (6) Could not resolve host: gateway-xxxx-xxxx-xxxx.local

<details>
<summary>🧰 Tools</summary>

<details>
<summary>🪛 Markdownlint</summary>

137-137: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

</details>

</details>

</blockquote></details>

</blockquote></details>

<details>
<summary>📜 Review details</summary>

**Configuration used: CodeRabbit UI**
**Review profile: CHILL**

<details>
<summary>📥 Commits</summary>

Reviewing files that changed from the base of the PR and between 7ce05f70d50703d30db9236afca9a78e9a3d4aa0 and 4f1319b03c9d5769a146ad3fcd2b6141a4db51cf.

</details>

<details>
<summary>📒 Files selected for processing (1)</summary>

* `source/_integrations/overkiz.markdown` (1 hunks)

</details>

<details>
<summary>🧰 Additional context used</summary>

<details>
<summary>🪛 LanguageTool</summary>

<details>
<summary>source/_integrations/overkiz.markdown</summary>

[style] ~135-~135: For conciseness, try rephrasing this sentence.
Context: ...ect to Tahoma  If you are using Docker, it's possible that the container running Home Assistant doesn't have access to t...

(MAY_MIGHT_BE)

</details>

</details>
<details>
<summary>🪛 Markdownlint</summary>

<details>
<summary>source/_integrations/overkiz.markdown</summary>

137-137: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

</details>

</details>

</details>

<details>
<summary>🔇 Additional comments (2)</summary>

<details>
<summary>source/_integrations/overkiz.markdown (2)</summary>

`133-133`: **LGTM!**

The section header is clear and follows the document's structure.

---

`132-142`: **Add verification steps for the solution.**

Consider adding a section that helps users verify their setup is working correctly.



Consider adding these verification steps to the documentation:
```markdown
To verify your setup:
1. Test the connection: `curl -I <your-gateway-ip>:8443`
2. Check Home Assistant logs for successful connection
3. Verify device discovery in Home Assistant
🧰 Tools
🪛 LanguageTool

[style] ~135-~135: For conciseness, try rephrasing this sentence.
Context: ...ect to Tahoma If you are using Docker, it's possible that the container running Home Assistant doesn't have access to t...

(MAY_MIGHT_BE)

🪛 Markdownlint

137-137: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

curl: (6) Could not resolve host: gateway-xxxx-xxxx-xxxx.local
```

Make sure Home Assistant has access to the service or use the IP address instead of the hostname.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Expand the solution with specific implementation steps.

The current solution lacks detailed guidance. Consider expanding it with specific steps:

-Make sure Home Assistant has access to the service or use the IP address instead of the hostname.
+To resolve this issue, you have two options:
+
+1. Enable DNS resolution in the Docker container:
+   - Add the following to your `docker-compose.yml`:
+     ```yaml
+     services:
+       homeassistant:
+         network_mode: host
+     ```
+   - Or use the `--network host` flag with `docker run`
+
+2. Use the IP address instead of the hostname:
+   - Find your Tahoma gateway's IP address from your router
+   - Replace `gateway-xxxx-xxxx-xxxx.local` with the IP address in your Home Assistant configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current This PR goes into the current branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants