Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LB] Added person_HassGetState sentences & responses #2139

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

theFeverDog
Copy link
Contributor

@theFeverDog theFeverDog commented Apr 15, 2024

  • Added lb person_HassGetState sentences, responses and tests
  • Adapted fixtures and common.yaml
  • Adapted HassGetState to remove "ass" (= Is) before a "No" answer for one_yesno

Summary by CodeRabbit

  • New Features

    • Introduced language understanding for Home Assistant to query the state of persons in different zones in Luxembourgish.
    • Added new intents for querying person states in different zones.
  • Enhancements

    • Updated response generation logic to include different messages based on state and query conditions.
    • Expanded functionality related to zones with a new zone entry having a wildcard attribute.
  • Tests

    • Added new test entities "Joseph," "Ada," and "John" with respective states for improved test coverage.

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @theFeverDog

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft April 15, 2024 19:56
@theFeverDog theFeverDog marked this pull request as ready for review April 16, 2024 08:43
@theFeverDog theFeverDog changed the title Added lb person_HassGetState sentences & responses [LB] Added person_HassGetState sentences & responses Apr 18, 2024
Copy link

coderabbitai bot commented May 24, 2024

Walkthrough

The changes introduce enhancements to the response generation logic for querying states in Home Assistant, particularly in Luxembourgish. This includes new conditional responses based on states and query parameters, additional language understanding capabilities, and new test fixtures for person states. The updates ensure more dynamic and context-aware responses.

Changes

File Path Change Summary
responses/lb/HassGetState.yaml Modified response logic to include conditional messages based on state and query parameters.
sentences/lb/_common.yaml Added a new zone entry with wildcard: true in the lists section to enhance zone-related functionalities.
sentences/lb/person_HassGetState.yaml Introduced new intents for querying person states in different zones in Luxembourgish.
tests/lb/_fixtures.yaml Added new entities "Joseph," "Ada," and "John" with their respective IDs and states ("doheem," "Aarbecht," "not_home").
tests/lb/person_HassGetState.yaml Added tests for querying the state of various individuals in Luxembourgish, ensuring the new response logic works as expected.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@theFeverDog
Copy link
Contributor Author

Is there anything else that needs to be done for a review?

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

tests/lb/_fixtures.yaml Outdated Show resolved Hide resolved
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

tests/lb/person_HassGetState.yaml Show resolved Hide resolved
Comment on lines +41 to +47
- "ass jiddereen doheem"
intent:
name: HassGetState
slots:
domain: person
state: doheem
response: "Nee, Ada an John net"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the logic for the response when querying if everyone is home.

The response "Nee, Ada an John net" might need clarification on why specifically these two are not home.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant