-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LB] Added person_HassGetState sentences & responses #2139
base: main
Are you sure you want to change the base?
[LB] Added person_HassGetState sentences & responses #2139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @theFeverDog
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
WalkthroughThe changes introduce enhancements to the response generation logic for querying states in Home Assistant, particularly in Luxembourgish. This includes new conditional responses based on states and query parameters, additional language understanding capabilities, and new test fixtures for person states. The updates ensure more dynamic and context-aware responses. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Is there anything else that needs to be done for a review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
- "ass jiddereen doheem" | ||
intent: | ||
name: HassGetState | ||
slots: | ||
domain: person | ||
state: doheem | ||
response: "Nee, Ada an John net" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check the logic for the response when querying if everyone is home.
The response "Nee, Ada an John net" might need clarification on why specifically these two are not home.
Summary by CodeRabbit
New Features
Enhancements
zone
entry having awildcard
attribute.Tests