Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NL] Finetune cover_HassSetPosition #2287

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

TheFes
Copy link
Contributor

@TheFes TheFes commented Jul 8, 2024

Changes:

  • Added sentences like doe bloemetjesgordijn omhoog naar 50%
  • Added sentences like doe slaapkamergordijnen naar 25% omlaag
  • make use of numeric_value_set expansion rule
  • add spaces inside optional parts instead of outside to avoid double spaces.
  • Add stand as variant for position
  • Allow stand|postition before the name (with optional van)
  • Add tests includling stand|position
  • Optionally add the afdekking expansion rule to names

It seems there is no support for floors for HassSetPosition. Is this intentional?

@TheFes
Copy link
Contributor Author

TheFes commented Jul 8, 2024

@frenck and another one :)

PS No code rabbit?

@TheFes TheFes changed the title [NL] Fineturen cover_HassSetPosition [NL] Finetune cover_HassSetPosition Jul 8, 2024
@TheFes TheFes marked this pull request as draft July 8, 2024 08:45
@TheFes TheFes marked this pull request as ready for review July 8, 2024 08:51
@TheFes TheFes merged commit 7d7bc65 into thefes_nl_covergetstate Nov 8, 2024
2 checks passed
@TheFes TheFes deleted the thefes_nl_coversetposition branch November 8, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant