[FR] Expand timer naming words

[bors-ltd]

I find it more natural to say "start a 5 minutes timer for the pizza".

The "surnommé" typo isn't strictly necessary, but it was bothering me.

[home-assistant]

Hi @bors-ltd

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[jlpouffier]

@bors-ltd Is the PR ready for review?
(Of yes mark it as such, I'll review it gladly ;) )

[bors-ltd]

Sorry, I was so excited when I found out Home Assistant had voice commands, I got carried away. It reminded me of Snips, glad I kept the devkit. Only later I noticed the test suite, and realised my changes were not covered. But I got busy today and couldn't come back to it. I'll ping you when it's thoroughly tested, and hopefully on real hardware when my ESP32 is delivered.

[bors-ltd]

Now I feel like pretty happy with the state of that PR, and confident to ask for a review.

Please note I'm new to HA, so it may likely not meet your quality standards, and I can accept criticism, even nitpicking.

Hopefully I didn't reach any hard limit with Whisper's current capabilities.

Stale

[piitaya]

Thank you for the very good job ! I just have a small comment about the implementation but overall it's pretty good 😀

[piitaya]

Also, we decided to have "Il reste combien" and "Combien de temps" but not "Combien" alone as it's too generic. Having one of the vert "reste" or the word "temps" must be required to avoid interference with other intents. "Combien" alone should be avoided.

[jlpouffier]

@bors-ltd Thx a lot for your PR and sorry for the delay reviewing it on my side.

My review is done, it's basically 3 small changes

• Merge two expansion rules ("Annule" and "Supprime")
• Add <le> into the expansion rule appele
• Make sure the sentences for timer status have more literal chunks of text to avoid having too short sentences such as "combien"

[bors-ltd]

Thanks for the review, I'll be implementing the changes ASAP.

[bors-ltd]

Updated my PR with all the suggestions/corrections.

I still have to test it in real life situations with my new buddy the ESP32-S3-Box-3 (which proved to be an even deeper rabbit hole...), so consider it a draft for now.

I'll keep the "Combien pour la pizza" on my personal HA, because I don't think I'll ever ask HA it the price of what I cook. 😜