Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vacuum variant to match without vacuum name #2560

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

duhow
Copy link
Contributor

@duhow duhow commented Nov 17, 2024

❗ NOTE: This adds a new slot_combination to Vacuum in intents.yaml, in order to skip specifying a name.

As the vacuum may have a different name than "vacuum", users will not trigger it by the entity name, but rather as "vacuum". This either forces the user to set an alias to the vacuum (named vacuum) to start it, or specify the full name for it.

@duhow duhow changed the title [CA] Add vacuum variant to match without vacuum name Add vacuum variant to match without vacuum name Nov 17, 2024
@duhow duhow added the enhancement New feature or request label Nov 17, 2024
@duhow duhow marked this pull request as ready for review November 17, 2024 13:40
@duhow duhow requested a review from balloob November 17, 2024 16:17
@tetele
Copy link
Contributor

tetele commented Nov 17, 2024

I don't think this will work without some modifications on the core repo, so that the concerned intents know how to handle no slots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants