Fixed: userInfo popup not showing on crossposts #5393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In crossposted posts the user tag was not visible and the user info popup didn't show when hovering. See screenshot: https://i.imgur.com/MlAPJFT.png The cause was that the element with CSS-class "tagline" is a <p> in normal posts, but it's a <div> in crospossted elements. Removing the element type on usernameSelector fixes this. Another option would be to keep "p.tagline a.author" and add "div.tagline a.author".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In crossposted posts the user tag was not visible and the user info popup didn't show when hovering. See screenshot: https://i.imgur.com/MlAPJFT.png
The cause was that the element with CSS-class "tagline" is a
<p>in normal posts, but it's a<div>in crospossted elements. Removing the element type inusernameSelectorfixes this.Another option would be to keep
p.tagline a.authorand adddiv.tagline a.author.Let me know if I missed anything and feel free to reject this PR and apply the fix on your own if that's easier.
Thanks.