-
-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add YouTube clips "expando" #5417
Add YouTube clips "expando" #5417
Conversation
- Can now expand and watch YouTube clips - Supports full embedded player functionality
2ca09e2
to
01ae815
Compare
01ae815
to
28eef6b
Compare
This API isn't doing anything other than being a proxy and returning the entire body of the uncached HTML body and searching for the link in the body. You could just as easily call Youtube directly. The reason embed.ly was used was because it cached the data so it wouldn't spam calls or have taxing responses. It's also easier to find in the This might be a solid alternative though, however, I'm unsure if it caches the data: |
Hey, good point. With caching in mind, I forked the original worker repository and changed it to just specifically handle our use-case with caching. You can see the project here: https://github.com/thomasasfk/web.scraper.workers.dev |
is there a reason why this isn't being added? |
No specific reason that this isn't specifically added, but in general: |
ah, thanks. I guess this is isn't something that could just be added via Tampermonkey by users? |
Image of the new expando option:
Video demo to see it in action;
https://user-images.githubusercontent.com/22506439/191857353-ee5bff89-7aef-4488-882c-73b3de544c99.mp4
I see there is an existing old implementation in #5358, which may still work. It however uses
https://opengraph.io/
and requires anapp_id
query parameter to extract the embed link, in contrast, the implementation in this PR useshttps://web.scraper.workers.dev/
to do the same thing, just without any required authentication.With that being said, it is a third-party dependency and could stop working or change it's underlying functionality, it may also end up hitting issues given YouTube's underlying implementation changes, although it is working at this time of raising this PR.
Relevant issue: #5344
Other implementations: #5358
Tested in browser: Chrome, Firefox