display: GCC 8.3 compatibility #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The code is built with -Werror and newer gccs warn on implicit fallthrough with -Wall -Wextra, so the build failed.
* The build failed with linker errors with gcc 8.3 (the inline functions could not be linked against). * The inline annotation were removed accordingly from functions that are linked, while those that are only used within one compilation unit were marked static inline instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code could no longer be built with gcc 8.3. See the commit messages for more details.
(A patch to the microbuilder codebase is required as well to build, this is not included in this PR).