Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code like this performs bounds check four times, and generates panicking code for four unique locations, which is relatively bloated for something as simple as writing four bytes.
OTOH assigning to a slice that is known to be 4 bytes long doesn't need extra bounds checks.
split_at_mut(4)
can create such slice, and advance the position in one go.I've also eliminated separate tracking of start position via
pos
field by advancing the slice itself. To get the amount of bytes written I use a pointer comparison. It doesn't requireunsafe
, because the pointer is only used as an integer, and not as a pointer, and the address difference is guaranteed to be valid for positions within a single slice.https://rust.godbolt.org/z/o95vE7rWT