Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add promise version of getPorts function #146

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MasterOdin
Copy link
Contributor

PR adds a new getPortsPromise function to allow using a promisified version of getPorts, similar to how there's a getPortPromise version of getPort. A test is included for the function, which mimics what I saw for testing getPortPromise.

I also fixed a type error which made it seem like the options parameter was required for getPorts, where it's optional, just need to always pass the count and callback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant