Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC of getting model_class from the Hub instead of having to pass a --feature #2

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

julien-c
Copy link
Member

@julien-c julien-c commented Sep 5, 2022

@hollance
Copy link
Contributor

hollance commented Sep 6, 2022

If we're going to go this route, I'd rather get rid of the feature argument altogether and not have two ways to achieve the same thing. But that's something we should really do together with the ONNX exporter.

@julien-c
Copy link
Member Author

julien-c commented Sep 6, 2022

+1 on removing the feature argument, and IMO it could be replaced by a model_class flag or similar, in cases where one wants to override the architecture

Re. ONNX, yes possibly we could do it in both at the same time?

@hollance
Copy link
Contributor

hollance commented Sep 6, 2022

One thing I want to do first is implement the with-past logic. Apparently this was one of the reasons for adding feature and it will affect some of the decisions we might make around this issue.

@julien-c
Copy link
Member Author

julien-c commented Sep 6, 2022

sounds good!

happy to share more info or doc about what's available on the Hub side in terms of transformers models metadata. cc @sgugger who's been working on this and knows how it works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants