Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eventloop executor #430

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Eventloop executor #430

wants to merge 5 commits into from

Conversation

adam-fowler
Copy link
Member

  • Add EventLoopExecutor
  • Add EventLoopExecutorMap to map EventLoop to an EventLoopExecutor
  • Require that ServerChildChannel.Value conforms to ChildChannelValue which returns an EventLoop
  • Server then gets the EventLoop from the ServerChildChannel.Value and runs the Task using the associated EventLoopExecutor

@adam-fowler adam-fowler marked this pull request as draft April 30, 2024 13:03
MahdiBM
MahdiBM reviewed May 3, 2024
View reviewed changes
Copy link
Contributor

@MahdiBM MahdiBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EventLoopExecutor sounds like something that should exist in NIO? Perhaps worth a PR there?

@adam-fowler
Copy link
Member Author

@MahdiBM it probably will in time. They already have a SerialExecutor. This PR is experimental at the moment. Unfortunately the results haven't been particularly successful so far. I might be holding it wrong though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MahdiBM MahdiBM MahdiBM left review comments

@Joannis Joannis Awaiting requested review from Joannis Joannis will be requested when the pull request is marked ready for review Joannis is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adam-fowler @MahdiBM