-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Door <-> IfcDoor conversion #1012
Added Door <-> IfcDoor conversion #1012
Conversation
The InstanceContentElement test fails in 70 of 100 runs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I assume that the Door.cs
definition will be unified with the one from the Doors
layout function.
Also, do you mind producing an IFC file with a door that I can review?
Reviewed 4 of 7 files at r1, 4 of 4 files at r3, all commit messages.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @srudenkoamc)
Elements/test/ContentTests.cs
line 94 at r3 (raw file):
} // TODO: The test fails in 70 of 100 test runs. Uncomment when it is fixed.
Did you get this working?
The About the test - I've just commented it for now because it sometimes does break the build and sometimes doesn't. Eric said that he worked with it and that he will take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4, 3 of 3 files at r5, all commit messages.
Reviewable status: complete! 1 of 1 approvals obtained
BACKGROUND:
DESCRIPTION:
TESTING:
FUTURE WORK:
This change is