Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ifc serialization improvements #1021

Merged
merged 81 commits into from
Nov 8, 2023
Merged

Ifc serialization improvements #1021

merged 81 commits into from
Nov 8, 2023

Commits on Aug 29, 2023

  1. Moved IFCExtensions to the IFCToElementsConverters folder 

    Also made extensions for basic geometric elements conversion (like vectors or transforms) internal instead of private.
    @srudenkoamc
    srudenkoamc committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    eb5621f View commit details
    Browse the repository at this point in the history

  2. Added names to walls in door test

    @srudenkoamc
    srudenkoamc committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    775e54e View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. Extended IFC4 test

    @srudenkoamc
    srudenkoamc committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    10744f1 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. Added ImportSolid : Solid Operation class

    @srudenkoamc
    srudenkoamc committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    def1390 View commit details
    Browse the repository at this point in the history

  2. Added IIfcProductToElementConverter interface

    @srudenkoamc
    srudenkoamc committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    898cfc1 View commit details
    Browse the repository at this point in the history

  3. Created a separate class-converter for each Element we recognize in IFC 

    The logic is taken from IFCExtensions mostly without changes. The only thing was excluded is openings processing. The openings will be processed separately.
    @srudenkoamc
    srudenkoamc committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    9ea63cc View commit details
    Browse the repository at this point in the history

  4. Added IfcBuildingElementToElementConverter class 

    The logic for the new class and the changes in IFCExtensions are taken from hypar-io#531 PR.
    @srudenkoamc
    srudenkoamc committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    5bc3e49 View commit details
    Browse the repository at this point in the history

  5. Added CompositeIfcToElementConverter class

    @srudenkoamc
    srudenkoamc committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    688af87 View commit details
    Browse the repository at this point in the history

  6. Added FromIfcModelProvider class

    @srudenkoamc
    srudenkoamc committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    f09d30e View commit details
    Browse the repository at this point in the history

  7. Use new IfcProduct -> Element logic instead of the old one

    @srudenkoamc
    srudenkoamc committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    070fefa View commit details
    Browse the repository at this point in the history

  8. IfcExtensions cleanup

    @srudenkoamc
    srudenkoamc committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    19c3dcf View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into ifc-serialization-refactoring

    @srudenkoamc
    srudenkoamc authored Sep 7, 2023
    Configuration menu
    Copy the full SHA
    176749d View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. Fix a visual artifact

    @srudenkoamc
    srudenkoamc committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    d01facc View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. Simplified the structure of the namespaces 

    No logic changes, just namespaces structure simplification.
    @srudenkoamc
    srudenkoamc committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    6948d30 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. Switched visibility of Ifc extensions to internal

    @srudenkoamc
    srudenkoamc committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    91f560a View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. Imported the materials extraction code

    @srudenkoamc
    srudenkoamc committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    8ec11cd View commit details
    Browse the repository at this point in the history

  2. Material extractor refactoring

    @srudenkoamc
    srudenkoamc committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    3135b48 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. Move building elements to BuildingElements namespace

    @srudenkoamc
    srudenkoamc committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    585c718 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. Switch expected and actual values in IFCTests.FromIFC4

    @srudenkoamc
    srudenkoamc committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    f9d6ee2 View commit details
    Browse the repository at this point in the history

  2. Revert 'Move building elements to BuildingElements namespace'

    @srudenkoamc
    srudenkoamc committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    96aca92 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. Added IndexedPolycurve conversion

    @srudenkoamc
    srudenkoamc committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    a14978c View commit details
    Browse the repository at this point in the history

  2. Added RepresentationData class and MappingInfo class

    @srudenkoamc
    srudenkoamc committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    eaf3ed8 View commit details
    Browse the repository at this point in the history

  3. Added Material extraction by representation item for MaterialExtractor

    @srudenkoamc
    srudenkoamc committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    4fc227f View commit details
    Browse the repository at this point in the history

  4. Added separate parsers for IfcRepresentationItems of different types

    @srudenkoamc
    srudenkoamc committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    6cb6520 View commit details
    Browse the repository at this point in the history

  5. Added Material and Representation parameters to Door constructor

    @srudenkoamc
    srudenkoamc committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    5829905 View commit details
    Browse the repository at this point in the history

  6. Added IfcRepresentationDataExtractor class

    @srudenkoamc
    srudenkoamc committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    45375aa View commit details
    Browse the repository at this point in the history

  7. Added a method that creates standard representation data extractor

    @srudenkoamc
    srudenkoamc committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    5637fad View commit details
    Browse the repository at this point in the history

  8. Imported Openings changes

    @srudenkoamc
    srudenkoamc committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    312f8bf View commit details
    Browse the repository at this point in the history

  9. Added default Extrude creation for openings

    @srudenkoamc
    srudenkoamc committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    8210c6f View commit details
    Browse the repository at this point in the history

  10. Used IfcRepresentationItem parsers to parse representation data for r… 

    …ecognized core types
    @srudenkoamc
    srudenkoamc committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    63eddd6 View commit details
    Browse the repository at this point in the history

  11. Added IfcSite converter

    @srudenkoamc
    srudenkoamc committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    a4394c1 View commit details
    Browse the repository at this point in the history

  12. Modified tests

    @srudenkoamc
    srudenkoamc committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    101076e View commit details
    Browse the repository at this point in the history

  13. Removed redundant methods

    @srudenkoamc
    srudenkoamc committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    e5385e8 View commit details
    Browse the repository at this point in the history

  14. Merge branch 'master' into ifc-serialization-refactoring

    @srudenkoamc
    srudenkoamc committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    c9c1149 View commit details
    Browse the repository at this point in the history

  15. Changed IfcBuildingElementToElementConverter to FromIfcElementConverter 

    The class now works with IfcElement rather than IfcBuildingElement.
    @srudenkoamc
    srudenkoamc committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    7c80d4d View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. Renamed converters from IFC

    @srudenkoamc
    srudenkoamc committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    7834d63 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. Renamed CompositeIfcToElementConverter

    @srudenkoamc
    srudenkoamc committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    c39ba87 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. Small refactoring in FromIfcModelProvider

    @srudenkoamc
    srudenkoamc committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    5383408 View commit details
    Browse the repository at this point in the history

  2. Fixed missing openings

    @srudenkoamc
    srudenkoamc committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    74c9262 View commit details
    Browse the repository at this point in the history

  3. Door class improvements 

     - Added missing summary.
 - Added id and name parameters to constructors.
 - Removed wall parameter from wall-free constructor.
 - Removed a method that isn't used anymore.
    @srudenkoamc
    srudenkoamc committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    e8b8b30 View commit details
    Browse the repository at this point in the history

  4. Added instancing for the core types

    @srudenkoamc
    srudenkoamc committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    c61c739 View commit details
    Browse the repository at this point in the history

  5. Included all IfcElements to conversion procedure (openings excluded)

    @srudenkoamc
    srudenkoamc committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    9009802 View commit details
    Browse the repository at this point in the history

  6. Small update of mapping transform

    @srudenkoamc
    srudenkoamc committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    50f83cf View commit details
    Browse the repository at this point in the history

  7. Updated FromIFC4 test

    @srudenkoamc
    srudenkoamc committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    717d10c View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into ifc-serialization-refactoring

    @srudenkoamc
    srudenkoamc authored Oct 5, 2023
    Configuration menu
    Copy the full SHA
    62e2873 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Default geometric element conversion improvements

    @srudenkoamc
    srudenkoamc committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    7a38d72 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'ifc-serialization-refactoring' of https://github.com/sr… 

    …udenkoamc/Elements into ifc-serialization-refactoring
    @srudenkoamc
    srudenkoamc committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    4e893f8 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into ifc-serialization-refactoring

    @srudenkoamc
    srudenkoamc authored Oct 10, 2023
    Configuration menu
    Copy the full SHA
    80b4116 View commit details
    Browse the repository at this point in the history

  4. Update IFCTests

    @srudenkoamc
    srudenkoamc committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    d767022 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. Fixed serialization issue for representations with imported solids

    @srudenkoamc
    srudenkoamc committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    18b316c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into ifc-serialization-refactoring

    @srudenkoamc
    srudenkoamc authored Oct 11, 2023
    Configuration menu
    Copy the full SHA
    d072bf8 View commit details
    Browse the repository at this point in the history

  3. Added extraction of solids from the first operand of boolean clipping… 

    … result representation

The boolean clipping operation is not applied to the extracted solid. It should be implemented later.
    @srudenkoamc
    srudenkoamc committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    c40a9cf View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. IFromIfcProductConverter refactoring

    @srudenkoamc
    srudenkoamc committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    cc047be View commit details
    Browse the repository at this point in the history

  2. Removed FromIfcSiteConverter

    @srudenkoamc
    srudenkoamc committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    f3babf4 View commit details
    Browse the repository at this point in the history

  3. Added summary for CompositeFromIfcProductConverter

    @srudenkoamc
    srudenkoamc committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    daa7369 View commit details
    Browse the repository at this point in the history

  4. Refactoring of FromIfcModelProvider 

    No logic changes
    @srudenkoamc
    srudenkoamc committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    e222c90 View commit details
    Browse the repository at this point in the history

  5. Refactoring of IIfcRepresentationParser

    @srudenkoamc
    srudenkoamc committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    3574f2f View commit details
    Browse the repository at this point in the history

  6. Added summaries to IfcRepresentationDataExtractor

    @srudenkoamc
    srudenkoamc committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    217c700 View commit details
    Browse the repository at this point in the history

  7. Added summaries for IfcMappedItemParser

    @srudenkoamc
    srudenkoamc committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    874470e View commit details
    Browse the repository at this point in the history

  8. Added summary for the constructor of IfcBooleanClippingResultParser

    @srudenkoamc
    srudenkoamc committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    dea87a6 View commit details
    Browse the repository at this point in the history

  9. Added summaries to MappingInfo

    @srudenkoamc
    srudenkoamc committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    49c470d View commit details
    Browse the repository at this point in the history

  10. Added summaries for MaterialExtractor

    @srudenkoamc
    srudenkoamc committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    ff8dd01 View commit details
    Browse the repository at this point in the history

  11. Added summaries for RepresentationData

    @srudenkoamc
    srudenkoamc committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    a947d40 View commit details
    Browse the repository at this point in the history

  12. Added comments about the future work to the tests

    @srudenkoamc
    srudenkoamc committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    0d37e78 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'master' into ifc-serialization-refactoring

    @srudenkoamc
    srudenkoamc authored Oct 19, 2023
    Configuration menu
    Copy the full SHA
    02d9039 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. Removed a commented function from IFCExtensions

    @srudenkoamc
    srudenkoamc committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    dafdefb View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2023

  1. Fixed Equals for IfcCartesianPoint

    @srudenkoamc
    srudenkoamc committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    118c554 View commit details
    Browse the repository at this point in the history

  2. Reverted SolidOperationUtils changes

    @srudenkoamc
    srudenkoamc committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    66eff79 View commit details
    Browse the repository at this point in the history

  3. FirstOrDefault and TryGetValue comments fixes

    @srudenkoamc
    srudenkoamc committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    6894f82 View commit details
    Browse the repository at this point in the history

  4. Fixes in FromIfcModelProvider

    @srudenkoamc
    srudenkoamc committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    85b868a View commit details
    Browse the repository at this point in the history

  5. Fixed extrudes null checks in ToOpenings

    @srudenkoamc
    srudenkoamc committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    1086b1e View commit details
    Browse the repository at this point in the history

  6. Added missing transforms in ToCurve and ToProfile

    @srudenkoamc
    srudenkoamc committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    16b01a8 View commit details
    Browse the repository at this point in the history

  7. Added Elements.Door to the Changelog

    @srudenkoamc
    srudenkoamc committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    c081bc6 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Merge branch 'master' into ifc-serialization-refactoring

    @srudenkoamc
    srudenkoamc authored Oct 25, 2023
    Configuration menu
    Copy the full SHA
    04d4cd9 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. Remove redundant comment

    @srudenkoamc
    srudenkoamc committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    980663e View commit details
    Browse the repository at this point in the history

  2. Added Guid generation for Door

    @srudenkoamc
    srudenkoamc committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    7cdcb81 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into ifc-serialization-refactoring

    @srudenkoamc
    srudenkoamc authored Oct 30, 2023
    Configuration menu
    Copy the full SHA
    fc0204c View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. Merge branch 'master' into ifc-serialization-refactoring

    @srudenkoamc
    srudenkoamc authored Nov 6, 2023
    Configuration menu
    Copy the full SHA
    c5788e6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into ifc-serialization-refactoring

    @srudenkoamc
    srudenkoamc authored Nov 6, 2023
    Configuration menu
    Copy the full SHA
    b969133 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. update to latest package

    @anthonie-kramer
    anthonie-kramer committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    6cf0264 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into ifc-serialization-refactoring

    @anthonie-kramer
    anthonie-kramer authored Nov 8, 2023
    Configuration menu
    Copy the full SHA
    20bcf69 View commit details
    Browse the repository at this point in the history