Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ToPolyline function in BoundedCurve #1041

Merged

Conversation

KaterynaSloboda
Copy link
Contributor

@KaterynaSloboda KaterynaSloboda commented Oct 23, 2023

BACKGROUND:

  • ToPolyline() function doesn't work for EllipticalArc

DESCRIPTION:

  • This PR fixes the ToPolyline() function inside the BoundedCurve class so that inheriting classes don't get errors. Including EllipticalArc

TESTING:

  • Call the new test Elements.Geometry.Tests.EllipticalArcTests.ToPolyline() or call the ToPolyline() method on any class that inherits BoundedCurve

FUTURE WORK:

  • Is there any future work needed or anticipated? Does this PR create any obvious technical debt?

REQUIRED:

  • All changes are up to date in CHANGELOG.md.

COMMENTS:

  • Any other notes.

This change is Reviewable

@DmytroMuravskyi
Copy link
Contributor

Just wanted to leave my 5 cents here that with this change Arc.ToPolyline is redundant as it's 100% same override as base class function.

@KaterynaSloboda
Copy link
Contributor Author

Just wanted to leave my 5 cents here that with this change Arc.ToPolyline is redundant as it's 100% same override as base class function.

Done

@wynged wynged merged commit 82071df into hypar-io:master Oct 26, 2023
1 check passed
@KaterynaSloboda KaterynaSloboda deleted the fix-EllipticalArc.ToPolyline-bug branch November 20, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants