Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make fittings using representation instances #1056

Merged
merged 5 commits into from
Nov 17, 2023
Merged

make fittings using representation instances #1056

merged 5 commits into from
Nov 17, 2023

Conversation

wynged
Copy link
Member

@wynged wynged commented Nov 14, 2023 •
edited by andrewheumann
Loading

BACKGROUND:

  • I used representation instances!

DESCRIPTION:

  • Adds a flag on the Component Base which chooses to use representation instances so that this is optional.

TESTING:

  • Tests continue to pass and I've used this in a function.

FUTURE WORK:

  • Should eventually tackle the other fitting types and straight segments.

REQUIRED:

  • All changes are up to date in CHANGELOG.md.

COMMENTS:

  • Any other notes.

This change is Reviewable

katehryhorenko
katehryhorenko approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@katehryhorenko katehryhorenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@wynged wynged merged commit 7db39fc into master Nov 17, 2023
2 checks passed
@wynged wynged deleted the fitting-representation-instances branch November 17, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katehryhorenko katehryhorenko katehryhorenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wynged @katehryhorenko