Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setting a different catalog #1079

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Fix setting a different catalog #1079

merged 1 commit into from
Mar 6, 2024

Conversation

andrewheumann
Copy link
Member

@andrewheumann andrewheumann commented Mar 6, 2024 •
edited
Loading

BACKGROUND:

  • Ancient catalog retrieval code assumed only a single catalog could exist. Setting a second catalog (as the Space Type function does) would fail — we would see we already had a catalog, and just use that, rather than reading the new one.
  • This meant that in cases where more than one space type was specified, all but the first one would be missing all properties.

DESCRIPTION:

  • Resets the catalog to null when setting a new path.

This change is Reviewable

katehryhorenko
katehryhorenko approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@katehryhorenko katehryhorenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@andrewheumann andrewheumann merged commit 896616d into master Mar 6, 2024
2 checks passed
@andrewheumann andrewheumann deleted the fix-set-new-catalog branch March 6, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katehryhorenko katehryhorenko katehryhorenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewheumann @katehryhorenko