Fix data race when calling get metadata #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The leader after a restart would grab the leader token and wait for a non-empty batch. In the new test the view thread of the leader after the restart is just about to call controller decide. However, before the provided fix, the controller is busy waiting for a new batch. Without any new transactions, the leader is stuck. In the fix, if the new batch is empty, the controller continues while reacquiring the leader token, thus allowing the view to call decide. Signed-off-by: Фёдор Партанский <[email protected]>
The leader after a restart would grab the leader token and propose while also calling GetMetadata. In the test the view thread of the leader after the restart is just about to call startNextSeq. This causes a data race. In the fix, the leader token is acquired only when the view is not in the middle of a decisionFix data race when calling GetMetadata. Signed-off-by: Фёдор Партанский <[email protected]>
C0rWin
approved these changes
Aug 26, 2023
# Conflicts: # test/basic_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.