remove append from crypto library #653
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adecaro
requested changes
Jun 14, 2024
| @@ -334,6 +334,7 @@ func GetAuditInfoForIssues(issues [][]byte, metadata []driver.IssueMetadata) ([] | |||
| if len(ia.OutputTokens) != len(md.ReceiversAuditInfos) || len(ia.OutputTokens) != len(md.OutputsMetadata) { | |||
| return nil, errors.Errorf("number of output does not match number of provided metadata") | |||
| } | |||
| outputs[k] = make([]*AuditableToken, len(md.ReceiversAuditInfos)) | |||
There was a problem hiding this comment.
if you allocate the array as
outputs[k] = make([]*AuditableToken, 0, len(md.ReceiversAuditInfos))Then you can keep append. The above call creates an array of size len(md.ReceiversAuditInfos) and 0 length.
| } | ||
| return raw, nil | ||
| return json.Marshal(raw) |
There was a problem hiding this comment.
better to avoid json here given that it is slow.
What you could do is to obtain the 3 slices you need and then aggregate them by allocating a new slice of size the sum of the 3 slices. Then you can use append.
There was a problem hiding this comment.
Hi @adecaro, I will use bytes.Join(raw, separator) instead. It seems to be fit for purpose.
Signed-off-by: Kaoutar <[email protected]>
Signed-off-by: Kaoutar <[email protected]>
Signed-off-by: Kaoutar <[email protected]>
Signed-off-by: Kaoutar <[email protected]>
Signed-off-by: Kaoutar <[email protected]>
Signed-off-by: Kaoutar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.