Optimization of fetcher with notifiers #733
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adecaro
requested changes
Aug 13, 2024
| func NewFetcherProvider(dbManager *tokendb.Manager, notifierManager *tokendb.NotifierManager, metricsProvider metrics.Provider, strategy FetcherStrategy) *fetcherProvider { | ||
| fetcher, ok := fetchers[strategy] | ||
| if !ok { | ||
| panic("undefined fetcher strategy: " + strategy) |
There was a problem hiding this comment.
why not returning an error here?
| if err := tokenNotifier.Subscribe(func(operation driver3.Operation, m map[driver3.ColumnKey]string) { | ||
| logger.Warnf("New operation %v: [%v]", operation, m) | ||
| }); err != nil { | ||
| panic(err) |
There was a problem hiding this comment.
why not returning an error here, so the code can resort to another strategy?
token/sdk/dig/sdk.go
Outdated
| p.Container().Provide(identitydriver.NewDriver, dig.Group("identitydb-drivers")), | ||
| p.Container().Provide(NewDBDrivers), | ||
| p.Container().Provide(func(dbManager *tokendb.Manager, notifierManager *tokendb.NotifierManager, metricsProvider metrics.Provider) sherdlock.FetcherProvider { | ||
| return sherdlock.NewFetcherProvider(dbManager, notifierManager, metricsProvider, sherdlock.Mixed) |
There was a problem hiding this comment.
show be the strategy configurable?
token/services/db/driverholder.go
Outdated
| @@ -28,13 +28,13 @@ type serviceProvider interface { | |||
| GetService(v interface{}) (interface{}, error) | |||
| } | |||
|
|
|||
| type dbDriver[D any] interface { | |||
| type DBDriver[D any] interface { | |||
There was a problem hiding this comment.
just Driver given that the package's name is db
Signed-off-by: Alexandros Filios <[email protected]>
alexandrosfilios
force-pushed
the
notifiers-2
branch
from
4cce636
to
5a9c229
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.