Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dummy PR #468

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .github/workflows/test_lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# Copyright IBM Corp. All Rights Reserved.
#
# SPDX-License-Identifier: CC-BY-4.0

name: Lint Test

on:
push:
branches: [ main ]
pull_request:
branches: [ main ]

jobs:
DCI-Lint:
name: DCI-Lint
runs-on: ubuntu-20.04
steps:
- id: lint-git-repo
name: Lint Git Repo
uses: petermetz/[email protected]
with:
lint-git-repo-request: '{"cloneUrl": "${{ github.server_url }}/${{ github.repository }}.git", "fetchArgs": ["--update-head-ok", "--no-tags", "--prune", "--progress", "--no-recurse-submodules", "--depth=1", "origin" ,"+${{ github.sha }}:${{ github.ref }}"], "checkoutArgs": [ "${{ github.ref }}"], "targetPhrasePatterns": [], "configDefaultsUrl": "https://inclusivenaming.org/json/dci-lint-config-recommended-v1.json" }'
- name: Get the output response
run: echo "${{ steps.lint-git-repo.outputs.lint-git-repo-response }}"
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import arrow.core.Either
import net.corda.core.serialization.SerializationWhitelist

// TODO: Documentation
class CustomSerializationWhitelist : SerializationWhitelist {
class CustomSerializationAllowlist : SerializationWhitelist {
override val whitelist: List<Class<*>> = listOf(
Either::class.java,
Either.Right::class.java,
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
com.weaver.corda.driver.CustomSerializationWhitelist
com.weaver.corda.driver.CustomSerializationAllowlist
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,18 @@ import arrow.core.Either
import net.corda.core.serialization.SerializationWhitelist

/**
* The CustomSerializationWhitelist class is used to define classes that should be
* The CustomSerializationAllowlist class is used to define classes that should be
* serializable by the Corda's wire protocol (based on AMQP 1.0).
*
* It extends the SerializationWhitelist interface and therefore overrides the whitelist
* property. This method of specifying whitelisted classes is need for the classes defined
* It extends the interface and therefore overrides the
* property. This method of specifying allowlisted classes is need for the classes defined
* here because they are from a third party library and therefore cannot be modified to
* include the @CordaSerializable annotation, which is otherwise the preferred method for
* whitelisting.
* allowlisting.
*
* @property whitelist The list of classes that are whitelisted for serialization.
* @property The list of classes that are allowlisted for serialization.
*/
class CustomSerializationWhitelist : SerializationWhitelist {
class CustomSerializationAllowlist : SerializationWhitelist {
override val whitelist: List<Class<*>> = listOf(
Either::class.java,
Either.Right::class.java,
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
com.weaver.corda.app.interop.flows.customSerializers.CustomSerializationWhitelist
com.weaver.corda.app.interop.flows.customSerializers.CustomSerializationAllowlist
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import arrow.core.Either
import net.corda.core.serialization.SerializationWhitelist

// TODO: Documentation
class CustomSerializationWhitelist : SerializationWhitelist {
class CustomSerializationAllowlist : SerializationWhitelist {
override val whitelist: List<Class<*>> = listOf(
Either::class.java,
Either.Right::class.java,
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
com.cordaSimpleApplication.client.CustomSerializationWhitelist
com.cordaSimpleApplication.client.CustomSerializationAllowlist
Loading