Adds a zombies game to a client/games folder #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reordered directories a bit.
hzeller
reviewed
Oct 31, 2019
| else: | ||
| return val | ||
|
|
||
| class Flaschen(object): |
There was a problem hiding this comment.
Would it be possible to use the library directly instead of creating a second copy which would need to be maintained ?
| self.screen = Flaschen(host='ft.noise', port=1337, width=WIDTH, height=HEIGHT, layer=5, transparent=False) | ||
| self.npcs = [] | ||
| self.heros = [Hero()] | ||
| self.main = Tk() |
There was a problem hiding this comment.
Is there an advantage to use a graphical window to receive key-presses vs. just simply from the terminal directly ?
It took me a while to realize that there was a tiny window popping up that I have to navigate the cursor in to even receive keypresses. It would be more natural to just have this as input on the terminal you invoke it.
(besides easier matching expectations, it is less dependencies, easier to play remotely etc.).
WDYT ?
|
Any Update ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.