Mapbox style multiple source #2128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-dutremble
force-pushed
the
mapbox_style
branch
9 times, most recently
from
dbdab8d
to
14c1f70
Compare
a-dutremble
force-pushed
the
mapbox_style
branch
from
14c1f70
to
7ee0f60
Compare
ftoromanoff
requested changes
Sep 12, 2023
src/Parser/VectorTileParser.js
Outdated
| return Promise.resolve(multiplePBF(file, options)); | ||
| } else { | ||
| return Promise.resolve(readPBF(file, options)); | ||
| } |
There was a problem hiding this comment.
If we think about the name and utility of this function, it is writen to parse a specifique file and thus it shouldn't be able to deal with a list of files.
a-dutremble
force-pushed
the
mapbox_style
branch
5 times, most recently
from
70ac825
to
505d176
Compare
a-dutremble
force-pushed
the
mapbox_style
branch
2 times, most recently
from
23323f2
to
b9b6976
Compare
ftoromanoff
force-pushed
the
mapbox_style
branch
from
4bc4e0d
to
691ad4f
Compare
ftoromanoff
force-pushed
the
mapbox_style
branch
8 times, most recently
from
d90933d
to
6165f16
Compare
AnthonyGlt
reviewed
Jan 29, 2024
ftoromanoff
force-pushed
the
mapbox_style
branch
from
945c06c
to
de3cc5e
Compare
AnthonyGlt
reviewed
Feb 5, 2024
ftoromanoff
force-pushed
the
mapbox_style
branch
3 times, most recently
from
a394721
to
830a9ca
Compare
ftoromanoff
previously approved these changes
Feb 9, 2024
ftoromanoff
force-pushed
the
mapbox_style
branch
from
b2d901b
to
3387459
Compare
ftoromanoff
force-pushed
the
mapbox_style
branch
from
3387459
to
d7e6cce
Compare
ftoromanoff
requested review from
AnthonyGlt and
ftoromanoff
and removed request for
ftoromanoff
ftoromanoff
force-pushed
the
mapbox_style
branch
from
d7e6cce
to
c27c1aa
Compare
ftoromanoff
force-pushed
the
mapbox_style
branch
from
c27c1aa
to
23e3c1d
Compare
AnthonyGlt
approved these changes
Mar 19, 2024
Desplandis
dismissed
ftoromanoff’s stale review
@ftoromanoff is now one of the main author of this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add multiple source Mapbox style support.
We've modified the entire process: source, url builder, fetcher and parser.
Motivation and Context
Fixes #1927
Follow up after the departure of Aymeric
I took this review into my hand and did the changes I found neccessary and improvment I think was needed. I choose not to delete the commit from aymeric to be able to see what he did before my changes. At the end before the merging, the commits will be squashed.