Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[coverage] Fix non source-mapped coverage issue #2383

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

Desplandis
Copy link
Contributor

@Desplandis Desplandis commented Aug 30, 2024

Description

The coverage was not correct since there was no source-map between the babel-compiled output and the original source code. This led to incorrect coverage reports (issue first found by @ftoromanoff) since those were based on the babel-compiled output.

This PR fixes on our unit tests:

  • the aforementioned source-map issue by using our own node module hook instead of the babel-register-esm one.
  • experimental warnings when using --experimental-loader options, we now use node:module.register() (not supported by babel-register-esm).
  • [BABEL] Note: The code generator has deoptimised the styling of [...]/node_modules/[...] as it exceeds the max of 500KB. warnings, since we now ignore compilation of modules in node_modules (not done by babel-register-ems but previously done by @babel/register).

Further info:

@Desplandis Desplandis marked this pull request as ready for review August 30, 2024 08:40
@Desplandis Desplandis merged commit 43a3c14 into iTowns:master Aug 30, 2024
9 checks passed
@Desplandis Desplandis deleted the fix/coverage branch September 23, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants