-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): add support for passing an optional index parameter to array map and filter #10205
Merged
cpcloud
merged 5 commits into
ibis-project:main
from
cpcloud:array-map-and-filter-with-index
Sep 25, 2024
Merged
feat(api): add support for passing an optional index parameter to array map and filter #10205
cpcloud
merged 5 commits into
ibis-project:main
from
cpcloud:array-map-and-filter-with-index
Sep 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
added
feature
Features or general enhancements
postgres
The PostgreSQL backend
clickhouse
The ClickHouse backend
bigquery
The BigQuery backend
duckdb
The DuckDB backend
snowflake
The Snowflake backend
trino
The Trino backend
labels
Sep 24, 2024
cpcloud
added
the
ci-run-cloud
Add this label to trigger a run of BigQuery, Snowflake, and Databricks backends in CI
label
Sep 24, 2024
ibis-docs-bot
bot
removed
the
ci-run-cloud
Add this label to trigger a run of BigQuery, Snowflake, and Databricks backends in CI
label
Sep 24, 2024
cpcloud
added
the
ci-run-cloud
Add this label to trigger a run of BigQuery, Snowflake, and Databricks backends in CI
label
Sep 24, 2024
ibis-docs-bot
bot
removed
the
ci-run-cloud
Add this label to trigger a run of BigQuery, Snowflake, and Databricks backends in CI
label
Sep 24, 2024
jcrist
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple small nits, overall this LGTM!
Co-authored-by: Jim Crist-Harif <[email protected]>
…array map and filter
cpcloud
force-pushed
the
array-map-and-filter-with-index
branch
from
September 25, 2024 09:12
6a3dfbd
to
68275f6
Compare
Clouds are passing:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR adds support for passing an additional zero-based index argument to
the callable of array map and filter.
Some of this is a hellscape.
arrayMap((x, i) -> do_stuff, arg, index)
.filter
to filter values after callingzip_with(arg, range, return_null_if_predicate_is_false)
.Issues closed
Closes #10201.