Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): use the correct exception type for a failed import #10430

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Nov 4, 2024

Fixes an issue with sqlglot backwards compatibility, where we were somehow catching AttributeError instead of ImportError.

@cpcloud cpcloud added this to the 10.0 milestone Nov 4, 2024
@cpcloud cpcloud added the bug Incorrect behavior inside of ibis label Nov 4, 2024
@github-actions github-actions bot added the sql Backends that generate SQL label Nov 4, 2024
@cpcloud cpcloud merged commit 00d83f3 into ibis-project:main Nov 4, 2024
78 of 79 checks passed
@cpcloud cpcloud deleted the fix-incorrect-exception-type branch November 4, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis sql Backends that generate SQL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant