chore(snowflake): patch oscrypto in the nix environment
#6955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
added
dependencies
cpcloud
force-pushed
the
patch-oscrypto
branch
from
4a4cef6
to
f9f8a7c
Compare
jcrist
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two tiny, related patches to
oscryptoin the nix environment.I discovered this problem by trying to run snowflake tests after a recent
nixpkgs update (ca2b023).
This update broke snowflake tests in the nix environment, due to a switch to
openssl 3 in that update.
Searching around the internets I found
dbt-labs/dbt-core#3366, which led me to
wbond/oscrypto#78 which is fixed upstream in
oscrypto.Nix has a solid patching mechanism for doing post-install surgery on packages,
which I use here to apply two patches that address the regex-version-searching
bug (the root cause of the original failure).
We can remove these when the next version of
oscryptois released to PyPI.