refactor(ir): merge ops.WindowFrame node into ops.WindowFunction
#8779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kszucs
changed the title
ops.WindowFrame and simplify the binding processops.WindowFrame and simplify the binding process [WIP]
kszucs
force-pushed
the
unbind-window-frame
branch
6 times, most recently
from
16150c4
to
00d857b
Compare
kszucs
changed the title
ops.WindowFrame and simplify the binding process [WIP]ops.WindowFrame node into ops.WindowFunction
kszucs
force-pushed
the
unbind-window-frame
branch
2 times, most recently
from
5b7de78
to
440935b
Compare
kszucs
force-pushed
the
unbind-window-frame
branch
from
440935b
to
295580f
Compare
kszucs
force-pushed
the
unbind-window-frame
branch
3 times, most recently
from
775d4be
to
69ef5f3
Compare
jcrist
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WindowFramewas only used byWindowFunctionadding an unnecessary indirection to the window abstraction. While merging them is useful from theIRperspective, backends likepandasmust extract the frame part so that the executor can reuse the window frame computation.