Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update minimum versions of dependencies to be accurate #8870

Closed
wants to merge 3 commits into from

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Apr 2, 2024

Description of changes

Updates minimum versions to be accurate. Tests against minimum versions in Python 3.9 unit tests.

Issues closed

Closes #8795

@tswast tswast marked this pull request as ready for review April 2, 2024 21:58
- name: install minimum versions of dependencies
run: |
pip install -r ci/requirements/requirements-${{ matrix.python-version }}.txt

- name: install ibis
run: poetry install --without dev --without docs --extras "visualization decompiler"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting Package operations: 6 installs, 0 updates, 9 removals so it looks like the lock file is overriding the minimum versions.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per python-poetry/poetry#2861

The easiest way to bypass poetry's locking, is to install the current project via pip: pip install . or pip install -e . for editable installs.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpcloud
Copy link
Member

cpcloud commented Apr 16, 2024

Closing in favor of #8977.

@cpcloud cpcloud closed this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: minimum version of pyarrow is incorrect
2 participants