Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(backends): remove now unused supports_divide_by_zero backend flag #8937

Merged
merged 1 commit into from
Apr 11, 2024
Merged

test(backends): remove now unused supports_divide_by_zero backend flag #8937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/contribute/05_reference.qmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ from ibis.backends.tests.base import BackendTest
class TestConf(BackendTest):
"""Backend-specific class with information for testing."""

supports_divide_by_zero = True
supports_floating_modulus = False
returned_timestamp_unit = "us"
supports_structs = True
Expand Down
1 change: 0 additions & 1 deletion ibis/backends/bigquery/tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
class TestConf(BackendTest):
"""Backend-specific class with information for testing."""

supports_divide_by_zero = True
supports_floating_modulus = False
returned_timestamp_unit = "us"
supports_structs = True
Expand Down
1 change: 0 additions & 1 deletion ibis/backends/datafusion/tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@

class TestConf(BackendTest):
# check_names = False
# supports_divide_by_zero = True
# returned_timestamp_unit = 'ns'
supports_structs = False
supports_json = False
Expand Down
1 change: 0 additions & 1 deletion ibis/backends/exasol/tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ class TestConf(ServiceBackendTest):
check_dtype = False
check_names = False
supports_arrays = False
supports_divide_by_zero = False
returned_timestamp_unit = "us"
supported_to_timestamp_units = {"s", "ms", "us"}
supports_floating_modulus = True
Expand Down
1 change: 0 additions & 1 deletion ibis/backends/impala/tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
class TestConf(BackendTest):
supports_arrays = True
check_dtype = False
supports_divide_by_zero = True
returned_timestamp_unit = "s"
supports_structs = False
supports_json = False
Expand Down
1 change: 0 additions & 1 deletion ibis/backends/pandas/tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
class TestConf(BackendTest):
check_names = False
supported_to_timestamp_units = BackendTest.supported_to_timestamp_units | {"ns"}
supports_divide_by_zero = True
returned_timestamp_unit = "ns"
stateful = False
rounding_method = "half_to_even"
Expand Down
2 changes: 0 additions & 2 deletions ibis/backends/tests/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,6 @@ class BackendTest(abc.ABC):
"Check that column name matches when comparing Pandas Series"
supports_arrays: bool = True
"Whether backend supports Arrays / Lists"
supports_divide_by_zero: bool = False
"Whether backend supports division by zero"
returned_timestamp_unit: str = "us"
supported_to_timestamp_units = {"s", "ms", "us"}
supports_floating_modulus: bool = True
Expand Down
Loading