fix: log DDL SQL in verbose mode #9816
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before (and still), we log the SQL inside Backend.compile(). I *think* what this means is that we are logging all SELECT statements. But, any DDL statements like from create_table() were not logged. Now they are. Some SQL statements may be logged twice now, in .compile() and in .raw_sql(), but I don't think that's a big problem?
|
Logging twice is not great. Production systems tend to already have problems with log spam, and we should not add to that problem. |
|
OK, that makes sense. If I come up with a way to not duplicate the logs, is this good to merge? |
|
I have several times run into bugs that are surfaced when I .cache() a table (and therefore .create_table() is called under the hood), and it is currently quite annoying to debug what SQL is actually getting executed. Setting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before (and still), we log the SQL inside Backend.compile().
I think what this means is that we are logging all SELECT statements.
But, any DDL statements like from create_table() were not logged.
Now they are.
Some SQL statements may be logged twice now, in .compile() and in .raw_sql(), but I don't think that's a big problem?