Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add argo functionality to QUEST #427

Merged
merged 140 commits into from
Dec 7, 2023
Merged

add argo functionality to QUEST #427

merged 140 commits into from
Dec 7, 2023

Conversation

JessicaS11
Copy link
Member

This PR will introduce the Argo (including BGC) retrieval functionality to QUEST.

kelseybisson and others added 30 commits February 23, 2022 09:26
@kelseybisson
Adding argo search and download script
b907af5
@kelseybisson
Create get_argo.py
fb5fc55 
Download the 'classic' argo data with physical variables only
@RomiP
begin implementing argo dataset
715440b
@RomiP
1st draft implementing argo dataset
d2260d6
@RomiP
implement search_data for physical argo
71cfedc
@RomiP
doctests and general cleanup for physical argo query
ec564fa
@RomiP
beginning of BGC Argo download
4fb5974
@RomiP
parse BGC profiles into DF
3bd2739
@RomiP
plan to query BGC profiles
06835d5
@RomiP
validate BGC param input function
dac11de
@RomiP
order BGC params in order in which they should be queried
dd47dc5
@RomiP
fix bug in parse_into_df() - init blank df to take in union of params…
88722a1 
… from all profiles
@RomiP
identify profiles from initial API request containing all required pa…
bf3cd70 
…rams
@RomiP
creates df with only profiles that contain all user specified params
fcb2422 
Need to dload additional params
@RomiP
modified to populate prof df by querying individual profiles
eb9c8ae
@RomiP
finished up BGC argo download!
1582f5b
@RomiP
assert bounding box type in Argo init, begin framework for unit tests
f55fd61
@kelseybisson @JessicaS11
Adding argo search and download script
d6d3872
@kelseybisson @JessicaS11
Create get_argo.py
7fc3b79 
Download the 'classic' argo data with physical variables only
@RomiP @JessicaS11
begin implementing argo dataset
195a4f1
@RomiP @JessicaS11
1st draft implementing argo dataset
df34424
@RomiP @JessicaS11
implement search_data for physical argo
390b7a9
@RomiP @JessicaS11
doctests and general cleanup for physical argo query
6824d27
@RomiP @JessicaS11
beginning of BGC Argo download
58092f9
@RomiP @JessicaS11
parse BGC profiles into DF
ae486f2
@RomiP @JessicaS11
plan to query BGC profiles
92f8a0d
@RomiP @JessicaS11
validate BGC param input function
0285be1
@RomiP @JessicaS11
order BGC params in order in which they should be queried
747af3a
@RomiP @JessicaS11
fix bug in parse_into_df() - init blank df to take in union of params…
cf600c6 
… from all profiles
@RomiP @JessicaS11
identify profiles from initial API request containing all required pa…
29ee8c4 
…rams
@JessicaS11
Copy link
Member Author

@zachghiaccio these are great - thank you! A few questions:

  1. since we're only viewing one file, how do you feel about limiting the dates so we only get a handful (say <5) granules? It was taking FOREVER to order and download all 19.
  2. After the long, 19 granule download failed (I presume because it was trying to create a top level directory on my computer?), I modified the date range and tried rerunning reg_a.download_all() and it successfully downloaded the IS2 but not the Argo (even though the parameters were still set). It kept ending up in the except saying dataset_name wasn't defined. The Argo object thus had no data associated with it.
  3. How slow/onerous was the plotting when you were reading in the IS2 data "manually" (i.e. before using the icepyx read module)? Was there a big change when you made the switch?

@JessicaS11 JessicaS11 merged commit 84f76ab into development Dec 7, 2023
2 checks passed
@JessicaS11 JessicaS11 deleted the argo branch December 7, 2023 17:10
JessicaS11 added a commit that referenced this pull request Jan 5, 2024
@JessicaS11 @kelseybisson
@RomiP @zachghiaccio
add argo functionality to QUEST (#427)
82881b7 
- add argo.py dataset functionality and implementation through QUEST
- demonstrate QUEST usage via example notebook
- add save to QUEST DataSet class template

Co-authored-by: Kelsey Bisson <[email protected]>
Co-authored-by: Romina <[email protected]>
Co-authored-by: zachghiaccio <[email protected]>
JessicaS11 added a commit that referenced this pull request Jan 5, 2024
@JessicaS11
Revert "add argo functionality to QUEST (#427)"
8d6b137 
This reverts commit 82881b7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomiP RomiP RomiP left review comments

@kelseybisson kelseybisson kelseybisson approved these changes

@zachghiaccio zachghiaccio zachghiaccio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JessicaS11 @zachghiaccio @kelseybisson @RomiP @whyjz @rwegener2