Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trigger to unit tests upon completion of UML action #619

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Conversation

JessicaS11
Copy link
Member

Addresses #618 by explicitly triggering the required unit tests after the UML action is run.

Copy link

github-actions bot commented Sep 27, 2024

Binder 👈 Launch a binder notebook on this branch for commit 8f27965

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit c8084a7

@JessicaS11 JessicaS11 linked an issue Sep 27, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.79%. Comparing base (628ad8f) to head (c8084a7).
Report is 1 commits behind head on development.

❗ There is a different number of reports uploaded between BASE (628ad8f) and HEAD (c8084a7). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (628ad8f) HEAD (c8084a7)
3 2
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #619      +/-   ##
===============================================
- Coverage        71.81%   66.79%   -5.02%     
===============================================
  Files               38       36       -2     
  Lines             3136     3078      -58     
  Branches           599      593       -6     
===============================================
- Hits              2252     2056     -196     
- Misses             773      933     +160     
+ Partials           111       89      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mfisher87 mfisher87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how this will interact with the required checks (i.e. will it mark the checks completed when the triggering event is another workflow?)! But let's give it a shot ;)

@JessicaS11
Copy link
Member Author

(i.e. will it mark the checks completed when the triggering event is another workflow?)! But let's give it a shot ;)

It appears to have - the UML diagrams test ran and both of the unit tests are now successfully reporting statuses.

image

@JessicaS11 JessicaS11 merged commit 23e3f7e into development Sep 27, 2024
8 of 9 checks passed
@JessicaS11 JessicaS11 deleted the ci-mgmt branch September 27, 2024 17:17
@mfisher87
Copy link
Member

🙌 Nice!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

branch protection tests not triggered after PR review auto-update
2 participants