Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes the "bad news" to be "good news" in the README #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

orowith2os
Copy link

:D

@JDJGInc
Copy link

JDJGInc commented Aug 23, 2022

why?

@orowith2os
Copy link
Author

The real question here is: why not?

@peter-dolkens
Copy link

Can we just ban losers like this that keep opening nonsense PRs?

@Reycko
Copy link

Reycko commented Oct 6, 2022

bruh, this is the original source code, not touched since 2011 (with most of the files being in their original 1993 state)
Don't send stupid PRs like that

@krovellium
Copy link

People are stupid. Live and learn

@Midway64
Copy link

Midway64 commented Mar 9, 2023

This is nonsense, this is supposed to be the ORIGINAL source code from 1997, if you want to do that then go ahead and make a new fork, might as well do some nonsense engine changes in it.

@@ -9,7 +9,7 @@ project and make sure that it actually works. Projects tends to rot if
you leave it alone for a few years, and it takes effort for someone to
deal with it again.

The bad news: this code only compiles and runs on linux. We couldn't
The good news: this code only compiles and runs on linux. We couldn't

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in that case, change the whole line to:

The good news: this code compiles and runs on linux.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some after thought, the README should contain things like how you get it up and running, I suggest instead reverting this change and renaming the file to FOREWORD.TXT

@johnsjob
Copy link

johnsjob commented Dec 27, 2023

First of all this is versioned so the original state can be checked out from 4eb368a (the initial commit)

So any changes applied are fine as we always have access to the original.

Second, even Carmack himself hoped, if you read the README, that there would be a collaborative effort in improving this codebase, instead having this archived and untouched.

Yes, anyone can fork, but then you are developing in isolation, like Carmack expected would happen, but wouldn't this be neat if we could actually collaborate and make this, for instance, even runnable stright out of the box?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

7 participants